Move lsp handlers to async/await. #81827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f511fcb.
Youssef1313
reviewed
Jan 1, 2026
| } | ||
|
|
||
| public Task OnInitializedAsync(ClientCapabilities clientCapabilities, RequestContext context, CancellationToken cancellationToken) | ||
| public async Task OnInitializedAsync(ClientCapabilities clientCapabilities, RequestContext context, CancellationToken cancellationToken) |
Member
There was a problem hiding this comment.
I'm curious to know some details about these efforts. Is that somehow related to the new runtime async stuff? IIRC, this used to produce warning along the lines of "this async method is lacking awaits and will run synchronously".
CyrusNajmabadi
closed this pull request by merging all changes
into
dotnet:main
in
5e6a0e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/results?buildId=13025692&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/697744